WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-ia64-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-ia64-devel] PATCH: mini-cleanup in vtlb.c

from [Aron Griffis] [Permanent Link][Original]
To: tgingold@xxxxxxx
Subject: Re: [Xen-ia64-devel] PATCH: mini-cleanup in vtlb.c
From: Aron Griffis <aron@xxxxxx>
Date: Sun, 16 Sep 2007 00:40:56 -0400
Cc: Alex Williamson <alex.williamson@xxxxxx>, Xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sat, 15 Sep 2007 21:46:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070916030422.GA5474@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: tgingold@xxxxxxx, Xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxx>
References: <20070916030422.GA5474@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.16 (2007-06-11) 
Hi Tristan,

tgingold@xxxxxxx wrote:  [Sat Sep 15 2007, 11:04:22PM EDT]
> -    rid = rid&RR_RID_MASK;;
> +    rid = rid & RR_RID_MASK;;

This appears twice in the cleanup, verbatim...  Couldn't it just be
rid &= RR_RID_MASK?  Also, why the double-semicolon?  I don't think
that means anything in C.

Thanks,
Aron

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [Xen-ia64-devel] PATCH: fill more registers for vcpu_getcontext, tgingold
Next by Date:  Re: [Xen-ia64-devel] Shall we put open source firmware source in XEN/IA64 tree, Aron Griffis
Previous by Thread:  [Xen-ia64-devel] PATCH: mini-cleanup in vtlb.c, tgingold
Next by Thread:  Re: [Xen-ia64-devel] PATCH: mini-cleanup in vtlb.c, Tristan Gingold
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy