Re: [Xen-ia64-devel] [patch 05/14] Kexec: partial port of CPU_HOTPLUG

[Horms <horms@xxxxxxxxxxxx>]

On Wed, Sep 12, 2007 at 12:20:47PM -0600, Alex Williamson wrote:
> On Wed, 2007-09-12 at 17:08 +0900, Simon Horman wrote:
> > 
> > +   /* Ensure that we are not runnable on dying cpu */
> > +   /* This is current->cpus_allowed on Linux,
> > +    * which may well work completely differently */
> > +   old_affinity = current->cpu_affinity;
> > +   tmp = (cpumask_t)CPU_MASK_ALL;
> > +   cpu_clear(cpu, tmp);
> 
>    Is it just me, or does this not do anything at all?
> 
> > Index: xen-unstable.hg/xen/include/asm-ia64/linux-xen/linux/cpu.h
> 
> README.origin in this directory also needs to be updated.

Sorry, I didn't know about the README.orgin scheeme.
I have probably missed this in a few other places too.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel