Re: [Xen-devel] [PATCH] xc_map_foreign_pages(), a convenient alternative to xc_map_foreign_batch()

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Wed, Sep 05, 2007 at 06:36:54PM +0200, Markus Armbruster wrote:
> The patch converts only those uses of xc_map_foreign_batch() to
> xc_map_foreign_pages() where I'm 100% sure it's safe.  For the others,
> I'd rather have a second opinion from somebody familiar with the code.
> 
> Discussion of uses:
...
> * main() in tools/ioemu/vl.c, in __ia64__ code
> 
>   Doesn't test for mapping failure.  Likely candidate for
>   xc_map_foreign_pages().

This can't be replaced because some pages, e.g. VGA area [0xA0000, 0xC0000),
can't be mapped.


> * copy_from_GFW_to_nvram() in tools/libxc/ia64/xc_ia64_hvm_build.c
> 
>   Doesn't test for mapping failure.  Likely candidate for
>   xc_map_foreign_pages(), but I have no way to test it.

This can be replaced with xc_map_foreign_pages()
This change will go through xen-ia64-devel.hg.
I'll send the patch to xen-ia64-devel.


> * xc_core_arch_map_p2m() in tools/libxc/xc_core_x86.c
> 
>   This maps a two level page directory: first a a page of pfns for the
>   page directory (live_p2m_frame_list_list), using that pages of pfns
>   for the pages themselves (live_p2m_frame_list), and using that the
>   actual pages.
> 
>   Doesn't test for mapping failure.  Likely candidate for
>   xc_map_foreign_pages().

This can be replaced with xc_map_foreign_pages().

-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel