Re: [Xen-ia64-devel][PATCH] SMBios table support in XEN

[Alex Williamson <alex.williamson@xxxxxx>]

On Thu, 2007-08-23 at 19:00 +0800, Zhang, Xing Z wrote:
> Hi Alex:
>       This patch used to get XEN version info and pass to GFW throuhg
> Hob. I tested it with other pathes which for GFW, OSI interface works
> fine with linux kernel 2.6.22.3.

Hi,

   Two comments.  First, check your indenting, it looks like you've got
tab indenting additions to space indented files in a few places.
Second, defining and using XENVER_UUID_LEN looks like a separate patch
that should be sent to xen-devel.  I don't see why there would be any
problem getting it in, but we can just as easily use 16 until we
standardize on the macro.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel