Re: [Xen-ia64-devel] PATCH: rbs in vcpu_guest_context_regs

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Fri, Jun 15, 2007 at 06:47:59AM +0200, tgingold@xxxxxxx wrote:

> +#if (IA64_RBS_OFFSET % 512) != IA64_GUEST_CONTEXT_RBS_OFFSET
> +# error "arch-ia64.h: IA64_GUEST_CONTEXT_RBS_OFFSET must be adjusted."
> +#endif
> +
...
> +#define IA64_GUEST_CONTEXT_RBS_OFFSET 448
>          unsigned long rbs[2048];
> -#endif
> +        unsigned long rbs_nat;
>  };


IA64_RBS_OFFSET is defined based on sizeof(struct vcpu),
so is IA64_GUEST_CONTEXT_RBS_OFFSET.
It means that IA64_GUEST_CONTEXT_RBS_OFFSET must be updated
every time struct vcpu/arch_vcpu are changed.
Although Xen/IA64 developper haven't taken care of ABI stability
so much, this case is too unstable.

Can we remove the constant and add another interface to get the value
dynamically?
-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel