On Mon, 2007-05-28 at 14:28 +0900, Horms wrote:
> [ Ian Campbell added to CC list ]
>
> On Tue, Sep 05, 2006 at 06:45:35AM +0900, Akio Takebe wrote:
> > Hi, Horms
> >
> > I tested the following patch with Horms kexec patch.
> >
> > My tests is:
> > push NMI bottun after loading kdump kernel.
> >
> > The results is:
> > OK, I could get vmcore
>
>
> Hi Takebe-san,
>
> this patch seems ok to me, but it seems that it never went into the
> tree. Ian, what are your thoughts on it?
The default in non-debug builds is to forward the crash to domain 0 so
we'd never get here, although I'd expect domain 0 probably does a kdump
itself nowadays when an NMI is received.
For debug builds I guess it does make sense. Assuming crash_kexec
gracefully returns if no crash kernel has been loaded, so that the old
behaviour is preserved, then the behaviour would be fine with me.
Alternatively "nmi=kdump" on the command line might be nice.
> > +extern void crash_kexec(struct cpu_user_regs *regs);
I can't find kexec_crash in xen-unstable. Is it now crash_kexec, with no
parameters? Whatever the function is now called it should probably be in
a header somewhere therefore no local prototype required.
> > + else if ( !nmi_watchdog ){
Needs a space between ) and {.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home