WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-devel] [PATCH] pygrub: look harder for elilo.conf

To: keir@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] pygrub: look harder for elilo.conf
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Thu, 3 May 2007 04:48:14 +0100
Delivery-date: Wed, 02 May 2007 20:46:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070503024240.GA8126@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070503024240.GA8126@xxxxxxxxx>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Wed, May 02, 2007 at 10:42:44PM -0400, Aron Griffis wrote:
> Keir,
> 
> This would also be appropriate for 3.1.0, since the /usr/lib fix makes
> pygrub work on ia64
> 
> Presently pygrub only looks in /efi/redhat/elilo.conf.  It should
> check for other distributions, plus a couple fallback locations.
> 
> Signed-off-by: Aron Griffis <aron@xxxxxx>
> 
> diff -r 6d64f9eefad5 -r 67df28389f46 tools/pygrub/src/pygrub
> --- a/tools/pygrub/src/pygrub Wed May 02 14:50:56 2007 -0400
> +++ b/tools/pygrub/src/pygrub Wed May 02 22:39:12 2007 -0400
> @@ -361,7 +361,12 @@ class Grub:
>  
>          if platform.machine() == 'ia64':
>              self.cf = grub.LiloConf.LiloConfigFile()
> -            file_list = ("/efi/redhat/elilo.conf",)
> +            # common distributions
> +            file_list = ("/efi/debian/elilo.conf", "/efi/gentoo/elilo.conf", 
> +                         "/efi/redflag/elilo.conf", 
> "/efi/redhat/elilo.conf", 
> +                         "/efi/SuSE/elilo.conf",)

How about simply having it iterate over every first level subdirectory of /efi,
ie basically looking for  /efi/*/elilo.conf  rather than hardcoding a small
list of distros ?

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>