WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [patch] SN2 specific SAL calls for dom0

To: Jes Sorensen <jes@xxxxxxx>
Subject: Re: [Xen-ia64-devel] [patch] SN2 specific SAL calls for dom0
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Wed, 28 Feb 2007 10:30:57 -0700
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 28 Feb 2007 09:30:17 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45E589B7.2010402@xxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <45E589B7.2010402@xxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2007-02-28 at 14:55 +0100, Jes Sorensen wrote:
> +           case SN_SAL_GET_MASTER_NASID:
> +               if (current->domain == dom0) {
> +                       printk("*** Emulating SN_SAL_GET_MASTER_NASID
> ***\n");
> +                       SAL_CALL_NOLOCK(ret_stuff,
> SN_SAL_GET_MASTER_NASID,
> +                                       0, 0, 0, 0, 0, 0, 0);
> +                       status = ret_stuff.status;
> +                       r9 = ret_stuff.v0;
> +                       r10 = ret_stuff.v1;
> +                       r11 = ret_stuff.v2;
> +                       break;
> +               } 

   Seems like these should break at the end regardless of whether it was
called from dom0.  Otherwise another case might sneak in that it could
fall into and do something bad.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>