RE: [Xen-devel] [PATCH 4/5 TAKE 2] xenoprof: make linux xenoprof codearch-generic

["Santos, Jose Renato G" <joserenato.santos@xxxxxx>]

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of 
> Isaku Yamahata
> Sent: Friday, November 17, 2006 8:22 PM
> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH 4/5 TAKE 2] xenoprof: make 
> linux xenoprof codearch-generic
> 
> 
> make xenoprof of linux side arch generic with some bug fixes.
> 
> Changes:
> - support modular oprofile
> - move xenoprof_is_primary from xenoprofile.c. 
>   It is referenced by perfmon which isn't module even when xenoprof
>   is module.
> 

   Why perfmon needs to access Oprofile? It should be the other way
around ...
   It seems that the only change was to create a new file named
xenoprof_is_primary.c to hold the definition of xenoprof_is_primary
   I don't like this. And I don't understand why you need this. You
should deal with IA64 specifics in arch specific code as much as
possible. Could you please find an IA64 specific solution or explain why
this is needed in the generic part? 

  Also, if sending another patch please send me only the changes from
the initial 5 patches you sent me. I would like to see only the changes
...
  (do not use this last patch as reference, I am ignoring it)
  Thanks

  Renato

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel