Re: [Xen-ia64-devel] PV-on-HVM for IPF (take 3)

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Mardi 29 Août 2006 13:50, DOI Tsunehisa a écrit :
> Hi all,
>
>   We have been porting PV-on-HVM feature for ia64 platform.
Hi,

I have a question about this modification:
void vcpu_flush_vtlb_all(struct vcpu *v)
 {
-       /* First VCPU tlb.  */
-       vcpu_purge_tr_entry(&PSCBX(v,dtlb));
-       vcpu_purge_tr_entry(&PSCBX(v,itlb));
-
-       /* Then VHPT.  */
-       vhpt_flush ();
-
-       /* Then mTLB.  */
-       local_flush_tlb_all ();
+       if (VMX_DOMAIN(v)) {
+               /* Purge vTLB for VT-i domain */
+               thash_purge_all(v);
+       }
+       else {
+               /* First VCPU tlb.  */
+               vcpu_purge_tr_entry(&PSCBX(v,dtlb));
+               vcpu_purge_tr_entry(&PSCBX(v,itlb));
+
+               /* Then VHPT.  */
+               vhpt_flush ();
+
+               /* Then mTLB.  */
+               local_flush_tlb_all ();
+       }

I don't really confortable with this modification.  I suppose you have to made 
it because of guest_physmap_remove_page.
You should add least add a comment because it is unusable to see VMX_DOMAIN() 
within paravirtualization area.

Tristan.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel