WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] PV-on-HVM driver for IPF

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: Re: [Xen-ia64-devel] PV-on-HVM driver for IPF
From: DOI Tsunehisa <Doi.Tsunehisa@xxxxxxxxxxxxxx>
Date: Mon, 28 Aug 2006 09:11:06 +0900
Cc: Tristan Gingold <Tristan.Gingold@xxxxxxxx>, xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sun, 27 Aug 2006 17:12:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200608272335.k7RNZ3Q11200@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <44EDA623.7020906@xxxxxxxxxxxxxx> <200608241546.25980.Tristan.Gingold@xxxxxxxx> <200608242347.k7ONlNQ19109@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <200608250910.21923.Tristan.Gingold@xxxxxxxx> <200608250731.k7P7VOQ01983@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <44EEB51C.4030303@xxxxxxxxxxxxxx> <44EEB87A.4070008@xxxxxxxxxxxxxx> <1156547609.5554.19.camel@lappy> <44EFE003.3000005@xxxxxxxxxxxxxx><1156689263.8384.14.camel@lappy> <200608272335.k7RNZ3Q11200@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.5 (Windows/20060719)
Doi.Tsunehisa@xxxxxxxxxxxxxx wrote:
> You (alex.williamson) said:
>> On Sat, 2006-08-26 at 14:45 +0900,  絎箙 wrote:
>>>  
>>> -    /* Copy existing grant table shared into new page */
>>> +    /* Copy existing grant table new page */
>>>      if (o_grant_shared) {
>>>          memcpy((void *)d->grant_table->shared,
>>>                 (void *)o_grant_shared, PAGE_SIZE * nr_frames);
>>    The existing comment seems to make more sense here.  Should it be
>> "Copy existing grant table into new page"?
> 
>   Thank you. I'll modify it.

  I'll post new fix-comment.patch2.

Thanks,
- Tsunehisa Doi
Signed-off-by: Tsunehisa Doi <Doi.Tsunehisa@xxxxxxxxxxxxxx>
Signed-off-by: Tomonari Horikoshi <t.horikoshi@xxxxxxxxxxxxxx>

diff -r 3e0685ecfe64 xen/arch/ia64/vmx/vmx_hypercall.c
--- a/xen/arch/ia64/vmx/vmx_hypercall.c Fri Aug 25 16:21:39 2006 -0600
+++ b/xen/arch/ia64/vmx/vmx_hypercall.c Mon Aug 28 09:08:38 2006 +0900
@@ -75,7 +75,7 @@ vmx_gnttab_setup_table(unsigned long fra
     o_grant_shared = (unsigned long)d->grant_table->shared;
     d->grant_table->shared = (struct grant_entry *)pgaddr;
 
-    /* Copy existing grant table shared into new page */
+    /* Copy existing grant table info new page */
     if (o_grant_shared) {
         memcpy((void *)d->grant_table->shared,
                (void *)o_grant_shared, PAGE_SIZE * nr_frames);
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel