Re: [Xen-ia64-devel] [PATCH] initial cleanup of ivt.S

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Vendredi 11 Août 2006 01:12, Al Stone a écrit :
> This patch reflects a patch I recently posted to the linux-ia64
> mailing list to do essentially the same thing for ivt.S in upstream
> source.
>
> I've reformatted the contents of the Xen version of ivt.S so that
> they are now readable on 80-column displays, in accordance with
> Linux coding standards.  This is really just a first pass at
> cleaning up this code.  In subsequent passes, I see several things
> need to be done:
>
>    1) Correct any additional typos or misspellings (there were
>       quite a few cleaned up in this patch).
>
>    2) Make the formatting consistent (use the same style of
>       comments everywhere, same syntax for stop bits,...).
>
>    3) Make sure the upstream and Xen ivt.S files are consistent
>       where they need to be.
IMHO, ivt.S is too far from linux ivt.S
A clean-up pass should be done: remove all #ifndef XEN code.
But you reformatting work is also a good thing.

>    4) Do all of the TODOs in the file.
>
>    5) Handle the FIXMEs.
>
>    6) Go through an optimization pass.
>
> In all of this patch, I only changed one line of assembly; there
> was a 'mov r31=pr;' in entry 23 (daccess_rights) that I changed
> to 'mov r31=pr;;' which is most likely what was meant.  No other
> instructions were changed.  Hopefully, I didn't harm any other
> white space formatting.
From what I read you could remove the ';;' stop bit.

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel