WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] increase buffer size in panic_domain()

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH] increase buffer size in panic_domain()
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Tue, 25 Jul 2006 09:47:39 -0600
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 25 Jul 2006 08:48:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060725040208.GC17396%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <20060725040208.GC17396%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2006-07-25 at 13:02 +0900, Isaku Yamahata wrote:
> --- a/xen/arch/ia64/xen/xenmisc.c       Mon Jul 24 21:25:30 2006 +0900
> +++ b/xen/arch/ia64/xen/xenmisc.c       Mon Jul 24 21:25:30 2006 +0900
> @@ -172,7 +172,7 @@ void panic_domain(struct pt_regs *regs, 
>  void panic_domain(struct pt_regs *regs, const char *fmt, ...)
>  {
>         va_list args;
> -       char buf[128];
> +       static char buf[1024]; 

Hi Isaku,

   The static here will cause problems if panic_domain() is called
concurrently from multiple CPUs.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>