| |
|
 |
|
 |
|
|
|
| |
|
|
xen-ia64-devel
Re: [Xen-ia64-devel] [PATCH] sparse tree cleanups
Hi, Alex
I agree your suggestion.
But your patch use ifdef CONFIG_XEN.
You say we use "simple is_running_on_xen() checks", aren't you?
Is this mistake? or do I mis-understand?
I want to clean up mm/memory.c.
(This work is for cleanup fedora-xen's warning.)
I should use is_running_on_xen() in mm/memory.c, shouldn't I?
diff -r 4e78528e3480 linux-2.6-xen-sparse/arch/ia64/kernel/irq_ia64.c
--- a/linux-2.6-xen-sparse/arch/ia64/kernel/irq_ia64.c Tue Jun 06 09:11:25
2006 -0600
+++ b/linux-2.6-xen-sparse/arch/ia64/kernel/irq_ia64.c Tue Jun 06 14:08:35
2006 -0600
@@ -66,11 +66,13 @@ assign_irq_vector (int irq)
assign_irq_vector (int irq)
{
int pos, vector;
-#ifdef CONFIG_XEN
- extern int xen_assign_irq_vector(int);
- if (is_running_on_xen())
+
+#ifdef CONFIG_XEN
+ if (is_running_on_xen()) {
+ extern int xen_assign_irq_vector(int);
return xen_assign_irq_vector(irq);
-#endif /* CONFIG_XEN */
+ }
+#endif
again:
pos = find_first_zero_bit(ia64_vector_mask, IA64_NUM_DEVICE_VECTORS);
vector = IA64_FIRST_DEVICE_VECTOR + pos;
diff -r 4e78528e3480 linux-2.6-xen-sparse/arch/ia64/kernel/setup.c
--- a/linux-2.6-xen-sparse/arch/ia64/kernel/setup.c Tue Jun 06 09:11:25
2006 -0600
+++ b/linux-2.6-xen-sparse/arch/ia64/kernel/setup.c Tue Jun 06 14:08:35
2006 -0600
@@ -416,6 +416,7 @@ setup_arch (char **cmdline_p)
setup_arch (char **cmdline_p)
{
unw_init();
+
#ifdef CONFIG_XEN
if (is_running_on_xen())
setup_xen_features();
@@ -933,6 +934,7 @@ cpu_init (void)
/* size of physical stacked register partition plus 8 bytes: */
__get_cpu_var(ia64_phys_stacked_size_p8) = num_phys_stacked*8 + 8;
platform_cpu_init();
+
#ifdef CONFIG_XEN
/* Need to be moved into platform_cpu_init later */
if (is_running_on_xen()) {
@@ -940,6 +942,7 @@ cpu_init (void)
xen_smp_intr_init();
}
#endif
+
pm_idle = default_idle;
}
Best Regards,
Akio Takebe
>Hi all,
>
> Here's a first pass at some sparse tree cleanups based on feedback
>we've gotten on linux-ia64. I haven't taken all of the comments into
>account yet, this is just a start. Specific changes:
>
>- CONFIG_ARCH_XEN is no longer necessary
>- simple is_running_on_xen() checks can be handled w/o CONFIG_XEN
>- pulled forward a drivers/xen/Makefile change that broken make clean
>- changed some comments from C++ style to C
>- turned HYPERVISOR_ioremap into a macro for !CONFIG_XEN
>- made hypervisor.h and privop.h include-able for !CONFIG_XEN
>
>Let me know if you have any comments. Thanks,
>
> Alex
>
>Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>
>
>--
>Alex Williamson HP Open Source & Linux Org.
>_______________________________________________
>Xen-ia64-devel mailing list
>Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-ia64-devel
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
|
|
|
| |
|
Home