WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] SetVirtualAddressMap emulation support

To: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-ia64-devel] [PATCH] SetVirtualAddressMap emulation support
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Mon, 24 Apr 2006 17:11:00 +0200
Delivery-date: Mon, 24 Apr 2006 08:07:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200604241445.AA02700@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200604241445.AA02700@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5
Le Lundi 24 Avril 2006 16:45, Masaki Kanno a écrit :
> Hi,
>
> I'm working on FPSWA support, and I'm thinking that I will offer
> a dummy fpswa function to dom0/domU. Therefore I think that Xen
> has to support the SetVirtualAddressMap() emulation of EFI.
> This patch supports the SetVirtualAddressMap() emulation in Xen.
>
> I confirmed that following EFI Runtime emulation worked in a
> virtual address.
>  - GetTime() in dom0
>  - GetTime() in domU
Hi,

Three points:
* you should write a generic function to do 
vcpu_tpa+__va(translate_domain_mpaddr).

* I prefer '|'
MAKE_MD(EFI_PAL_CODE,EFI_MEMORY_WB|EFI_MEMORY_RUNTIME,HYPERCALL_START,HYPERCALL_END,1);
instead of '+'
MAKE_MD(EFI_PAL_CODE,EFI_MEMORY_WB+EFI_MEMORY_RUNTIME,HYPERCALL_START,HYPERCALL_END,1);

* You don't handle vcpu_tpa failure.  This may never happen for GetTime, but 
fore sure may happen for other calls.
This may be not trivial.

Thank you.
Tristan.

                


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>