Re: [Xen-ia64-devel] alt_itlb_miss?

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi Kevin,

Tian, Kevin wrote:
>>From: Alex Williamson
>>Sent: 2006定4埖20晩 20:24
>>On Thu, 2006-04-20 at 17:58 +0900, Masaki Kanno wrote:
>>> Hi,
>>>
>>> Because I was a business trip yesterday, I was behind with reading an
>>> email of all of you.
>>>
>>> I'm working on FPSWA support now.
>>> I inserted FPSWA codes in ITC with the below patch, and I passed
>>tests
>>> of a floating point by LTP. Please give me comment.
>>
>>Hi Kan,
>>
>>   Thanks, this looks like exactly what we need.  If there are no other
>>comments, please send me this patch w/ a Signed-off-by and we can get
>>it
>>in tree.  BTW, glad to hear you're working on the FPSWA issue and are
>>making good progress!  Thanks,
>>
>>      Alex
>
>Seems OK. One small comment is that we may also remove 
>FORCE_CRASH completely since the assumption to add that 
>check doesn't exist now. Actually VHPT_CCHAIN_LOOKUP 
>already makes check upon VMM area to decide whether jumping 
>to alt_itlb_miss handler. In this case, simply removing 
>FORCE_CRASH line can also work. :-)

If alt_itlb_fault occurred, we need ifa checking and FORCE_CRASH, don't we?
Therefore I don't need to change my patch, do I?



>BTW, this reminds me another interesting point raised several 
>months ago when Isaku suspected why there's no logic to handle 
>identity mapped area within dtlb_miss handler. Finally Isaku copied
>logic from alt_dtlb_miss handler into dtlb_miss handler as we see 
>today. Seems that's also covered by VHPT_CCHAIN_LOOKUP and 
>those duplicated logic added in dtlb_miss can be also removed now.
>
>Thanks,
>Kevin
>


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel