 Home |
Products |
Support |
Community |
News |
xen-ia64-devel
Re: [Xen-ia64-devel] [RFC] The "vcpu->arch.privregs" is doubly used
| To: | xen-ia64-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [Xen-ia64-devel] [RFC] The "vcpu->arch.privregs" is doubly used |
| From: | Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx> |
| Date: | Mon, 20 Mar 2006 19:00:21 +0900 |
| Delivery-date: | Mon, 20 Mar 2006 10:01:44 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <200603200844.AA02432@xxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help> |
| List-id: | Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com> |
| List-post: | <mailto:xen-ia64-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <200603200844.AA02432@xxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Hi,
Sorry. Because size is not same as the mapped_regs_t structure as for
the vpd structure, my patch cannot solve a problem. Maybe the "destroy"
processing will become wrong.
Best regards,
Kan
Masaki Kanno wrote:
>Hi,
>
>I found the "vcpu->arch.privregs" being doubly used.
>Please refer to the following functions.
>
> - alloc_vcpu_struct() : xen/arch/ia64/xen/domain.c
> - vmx_final_setup_guest() : xen/arch/ia64/vmx/vmx_init.c
>
>I suggest the following patch. Please comment.
>
>Best regards,
> Kan
>
>diff -r 25003dd43a92 xen/arch/ia64/vmx/vmx_init.c
>--- a/xen/arch/ia64/vmx/vmx_init.c Fri Mar 17 15:37:28 2006 -0700
>+++ b/xen/arch/ia64/vmx/vmx_init.c Mon Mar 20 17:35:23 2006 +0900
>@@ -261,6 +261,8 @@ vmx_final_setup_guest(struct vcpu *v)
> {
> vpd_t *vpd;
>
>+ free_xenheap_pages(v->arch.privregs, get_order(sizeof(mapped_regs_t)));
>+
> vpd = alloc_vpd();
> ASSERT(vpd);
>
>
>
>_______________________________________________
>Xen-ia64-devel mailing list
>Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-ia64-devel
>
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-ia64-devel] [PATCH]: huge security hole, Tristan Gingold |
|---|---|
| Next by Date: | [Xen-ia64-devel] [PATCH]: allow hypercalls only from kernels., Tristan Gingold |
| Previous by Thread: | [Xen-ia64-devel] [RFC] The "vcpu->arch.privregs" is doubly used, Masaki Kanno |
| Next by Thread: | RE: [Xen-ia64-devel] [RFC] The "vcpu->arch.privregs" is doubly used, Tian, Kevin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
