Hi,
We agree first option.
But we think that we change it slowly because there are many change points.
We think that the following are change steps.
1. Change from "page" to "page_info" in xen/arch/ia64/xen/*.c and
xen/include/asm-ia64/*.h.
2. Remove unnecessary "page" in xen/arch/linux-xen/*.c,
xen/include/asm-ia64/linux-xen/*.h
and xen/include/asm-ia64/linux/*.h.
3. Remove "#define page_info page" in xen/include/asm-ia64/config.h.
Best regards,
Kan and Akio
Tian, Kevin wrote:
>>From: Masaki Kanno
>>Sent: 2006定3埖16晩 16:32
>>
>>Hi,
>>
>>We thought that there might be the comment that you should have
>>unified
>>to "page_info", but it was our unnecessary worry.
>>Because this patch did not have comment, please apply this patch.
>
>Yes, here comes comment. :-) A naming choice here:
> - define structure page_info in mm.h, and define page as a macro to
>page_info, which sticks to xen's convention since all other places
>(common, x86 specific, etc) are referred by page_info
> - Or define structure page in mm.h, as what you're approaching,
>which towards linux style since we have still a set of linux files copied
>there
>
>Yes, nothing differed in final binary, however to me it's more natural for
>first option, since gradually we'll remove all unnecessary linux stuff. Patch
>to remove using "page" may be more welcomed instead...
>
>Thanks,
>Kevin
>>
>>Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
>>Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
>>
>>Best regards,
>> Kan, and Fujitsu team
>
>
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
|
Home