RE: [Xen-ia64-devel] [PATCH]Guarantee VTi guest can get correctfrequency base

["Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>]

Hi Alex,
        Because the implementation of guest firmware has assumed providing 
frequency base for VMs through pal call even if the native guest os may get it 
from sal call. Maybe we should support the interface of sal emulatation in VMM 
in future. But currently due to only the sal_freq_base needs to emulate by VMM, 
we adopt the substitute method to provide the frequency base for VMs' 
sal_freq_base calls. 

Thanks  
     Xiantao
CSD-OTC PRC Virtualization 
Intel (China) Limited 
> -----Original Message-----
> From: Alex Williamson [mailto:alex.williamson@xxxxxx]
> Sent: 2006年3月6日 23:26
> To: Zhang, Xiantao
> Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-ia64-devel] [PATCH]Guarantee VTi guest can get
> correctfrequency base
> 
> On Mon, 2006-03-06 at 16:19 +0800, Zhang, Xiantao wrote:
> 
> >      PAL_CALL(result,PAL_FREQ_BASE, 0, 0, 0);
> > +    if(result.v0 == 0){
> > //PAL_FREQ_BASE may not be implemented in some platforms, call SAL
> > instead.
> 
>    Should this be checking result.status == -1 (unimplemented)?
> 
> > +        SAL_CALL(isrv, SAL_FREQ_BASE,
> > +                SAL_FREQ_BASE_PLATFORM, 0, 0, 0, 0, 0, 0);
> 
>    I'm not sure I understand why pal_freq_base() must return something.
> Shouldn't any VMs trying to call PAL_FREQ_BASE be prepared for an
> unimplemented return and then try SAL_FREQ_BASE instead?  Thanks,
> 
>       Alex
> 
> --
> Alex Williamson                             HP Linux & Open Source Lab


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel