WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86/IO-APIC: refine EOI-ing of migrating level i

To: "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86/IO-APIC: refine EOI-ing of migrating level interrupts
From: "Jan Beulich" <JBeulich@xxxxxxxx>
Date: Tue, 15 Nov 2011 13:27:53 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 15 Nov 2011 05:28:43 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4EC266E3.50706@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4EC273B40200007800061145@xxxxxxxxxxxxxxxxxxxx> <4EC266E3.50706@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 15.11.11 at 14:19, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 15/11/11 13:14, Jan Beulich wrote:
>>      if ( ioapic_has_eoi_reg(apic) )
>>      {
>>          /* If vector is unknown, read it from the IO-APIC */
>> -        if ( vector == -1 )
>> +        if ( vector == IRQ_VECTOR_UNASSIGNED )
> 
> Quick style query:  I consider IRQ_VECTOR_UNASSIGNED logically different
> from passing -1 in as a value for vector, even though they are the are
> the same value.  Is it sensible to mix them?

I view it quite the other way around: One should explicitly pass
IRQ_VECTOR_UNASSIGNED when passing a literal value (which
currently doesn't happen anyway. Primarily because passing
desc->arch.vector or desc->arch.old_vector could happen to also
hold this very value.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel