WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1 of 2] Add linker flags to makefile rules to ena

To: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1 of 2] Add linker flags to makefile rules to enable cross compiling
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 15 Nov 2011 08:55:51 +0000
Cc: "andres@xxxxxxxxxxxxxx" <andres@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "adin@xxxxxxxxxxxxxx" <adin@xxxxxxxxxxxxxx>
Delivery-date: Tue, 15 Nov 2011 00:56:57 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <bf47f7aaf6694e6318dc.1321307632@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1321307631@xxxxxxxxxxxxxxxxxxx> <bf47f7aaf6694e6318dc.1321307632@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2011-11-14 at 21:53 +0000, Andres Lagar-Cavilla wrote:
> config/x86_32.mk |  1 +
>  config/x86_64.mk |  1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> 
> For cross-compiling, the link step must also include necessary architecture
> flags (otherwise there's a mismatch between input objects and the output we're
> trying to produce).
> 
> Signed-off-by: Adin Scannell <adin@xxxxxxxxxxx>
> 
> diff -r 1f9e4cde0093 -r bf47f7aaf669 config/x86_32.mk
> --- a/config/x86_32.mk
> +++ b/config/x86_32.mk
> @@ -8,6 +8,7 @@ CONFIG_XCUTILS := y
>  CONFIG_IOEMU := y
>  
>  CFLAGS += -m32 -march=i686
> +LDFLAGS += -m32 -march=i686

I think when Adin posted this we determined that it only worked by
coincidence, since when we invoke ld directly it is as
        ld $(LDFLAGS) -melf_x86_64
so while -m32 -march= are unknown to ld the -nelf_xx (which is a valid
ld option) takes precedence and things work ok.

The consensus then was that we need to split LDFLAGS-for-gcc-as-linker
from LDFLAGS-for-ld-directly into two variables. See Jan's response in
<4E844703020000780005868E@xxxxxxxxxxxxxxxxxxxx>.

Ian.

>  
>  # Use only if calling $(LD) directly.
>  LDFLAGS_DIRECT_OpenBSD = _obsd
> diff -r 1f9e4cde0093 -r bf47f7aaf669 config/x86_64.mk
> --- a/config/x86_64.mk
> +++ b/config/x86_64.mk
> @@ -9,6 +9,7 @@ CONFIG_XCUTILS := y
>  CONFIG_IOEMU := y
>  
>  CFLAGS += -m64
> +LDFLAGS += -m64
>  
>  LIBLEAFDIR = $(LIBLEAFDIR_x86_64)
>  LIBDIR = $(LIBDIR_x86_64)
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>