WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 9 of 9] Modify all call sites of queries into the

To: "Tim Deegan" <tim@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 9 of 9] Modify all call sites of queries into the p2m to use the new fine-grained locking
From: andres@xxxxxxxxxxxxxxxx
Date: Wed, 2 Nov 2011 07:32:55 -0700
Cc: olaf@xxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, andres@xxxxxxxxxxxxxx, keir.xen@xxxxxxxxx, Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>, adin@xxxxxxxxxxxxxx
Delivery-date: Wed, 02 Nov 2011 07:33:33 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed; d=lagarcavilla.com; h= message-id:in-reply-to:references:date:subject:from:to:cc :mime-version:content-type:content-transfer-encoding; s= lagarcavilla.com; bh=dMipiz3MyORwvZ4Ekrvt5HfYmVw=; b=QQiVlbvk9nr YTC0rhoRZJp3XR1RmF0uMUunKIYcjjPZTOT9oyEG4+glUVNrbnwrmkajYBITEomn dKjWRWrzeqH84IthntvmZAi9rQlszDRhexCc9WJoTYNxP9GyaIfPsp8y5uMCEke1 Ht+TtoOEj6iJcdyjY0ski8zXHJxmP7bE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=lagarcavilla.com; h=message-id :in-reply-to:references:date:subject:from:to:cc:mime-version :content-type:content-transfer-encoding; q=dns; s= lagarcavilla.com; b=pCOCfsmykj9s+QRmpGMIBmc+NGNv6AaYMUukdpxA70Se g30kvo6CCEhdaPFDrVSGdqloCiDBGbJSZQU4j2qYkd3xCDvCUbe7gjH6+aKv5683 MPpITj8+BivdTle7gWUnvLpYG83aBu9MqnmBMq/Qbnge2CgjmHvYBZa63YjMNl4=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20111027150207.GO59656@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1319690025@xxxxxxxxxxxxxxxxxxx> <d13f91c2fe18d58ad27f.1319690034@xxxxxxxxxxxxxxxxxxx> <20111027150207.GO59656@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: SquirrelMail/1.4.21
I don't know that a massive sed on all these names is a good idea. I guess
forcing everyone to compile-fail will also make them realize they need to
add a call to drop the p2m locks they got...

Can you elaborate on the naming preferences here: would you prefer
gfn_to_mfn/put_gfn? get_p2m_gfn/put_p2m_gfn? get_gfn/put_gfn

Andres

> At 00:33 -0400 on 27 Oct (1319675634), Andres Lagar-Cavilla wrote:
>>  28 files changed, 519 insertions(+), 101 deletions(-)
>
> And I thought patch 5 was big :)
>
> I'm not going to read the detail of this this time around - I'd like to
> only have to review it once. :)
>
> I wonder whether it would be worth changing the name/signature of the
> generic p2m functions in an incompatime way while we're there.  It would
> have three advantages:
>
>  - allow the lookup/drop pairs to have nice matching names
>  - get rid of the confusingly-named 'gmfn_to_mfn' function
>  - avoid later bugs if patches are forward-ported across this chaneg
>    that add p2m lookups (but not corresoponding drops)
>
> Tim.
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>