WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xenstored: Fix processing of zero-length message

To: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xenstored: Fix processing of zero-length messages
From: Vasiliy Tolstov <v.tolstov@xxxxxxxxx>
Date: Tue, 1 Nov 2011 08:18:11 +0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 31 Oct 2011 21:19:18 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfip.ru; s=google; h=mime-version:sender:x-originating-ip:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type; bh=Tn62ZdNOIwgNwERpAD+FBaZ2VYZYG4wuOniY5VEcf48=; b=aG3ODIZqcGDwy+cWeVtB0i62ZnTb9+tzbanqc78K4E1BGbWkG8qr7zG8ipee3eAbEx /no9wcXle5Xh15RyCxbzJFTiTDgJ9oEkbxp8cU8+KZK8kdVndGD/Gp5XjM+8OHveEOSD K/oeGejXmh7HeOQ5DEv2a/Bmle8ravVa05TAI=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1320086292-5058-1-git-send-email-dgdegra@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1320086292-5058-1-git-send-email-dgdegra@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thanks! Can somebody check ocaml oxenstored for deadlocks when incorrect messages sent to xenstore?

2011/10/31 Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
When a message with zero length is sent to xenstore, the body of the
message was not processed until the socket or ring had more data to
read; this will cause deadlocks if the requestor is waiting on a
response to continue.

Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
---
 tools/xenstore/xenstored_core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 5d308ca..9e6c2c7 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -1297,7 +1297,6 @@ static void handle_input(struct connection *conn)
                       goto bad_client;
               in->used = 0;
               in->inhdr = false;
-               return;
       }

       bytes = conn->read(conn, in->buffer + in->used,
--
1.7.6.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel



--
Vasiliy Tolstov,
Clodo.ru

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>