WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH RFC v2 10/13] libxl: make libxl__[v]log const-cor

To: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH RFC v2 10/13] libxl: make libxl__[v]log const-correct
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Mon, 31 Oct 2011 10:04:55 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 31 Oct 2011 03:09:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1319827031-15395-11-git-send-email-ian.jackson@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1319827031-15395-1-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-2-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-3-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-4-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-5-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-6-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-7-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-8-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-9-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-10-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-11-git-send-email-ian.jackson@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-10-28 at 19:37 +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  tools/libxl/libxl_internal.c |    4 ++--
>  tools/libxl/libxl_internal.h |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c
> index dd31f25..df2b7f8 100644
> --- a/tools/libxl/libxl_internal.c
> +++ b/tools/libxl/libxl_internal.c
> @@ -179,7 +179,7 @@ char *libxl__dirname(libxl__gc *gc, const char *s)
>  
>  void libxl__logv(libxl_ctx *ctx, xentoollog_level msglevel, int errnoval,
>               const char *file, int line, const char *func,
> -             char *fmt, va_list ap)
> +             const char *fmt, va_list ap)
>  {
>      char *enomem = "[out of memory formatting log message]";
>      char *base = NULL;
> @@ -206,7 +206,7 @@ void libxl__logv(libxl_ctx *ctx, xentoollog_level 
> msglevel, int errnoval,
>  
>  void libxl__log(libxl_ctx *ctx, xentoollog_level msglevel, int errnoval,
>              const char *file, int line, const char *func,
> -            char *fmt, ...)
> +            const char *fmt, ...)
>  {
>      va_list ap;
>      va_start(ap, fmt);
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 79a9de4..fe64d34 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -80,13 +80,13 @@
>  _hidden void libxl__logv(libxl_ctx *ctx, xentoollog_level msglevel, int 
> errnoval,
>               const char *file /* may be 0 */, int line /* ignored if !file 
> */,
>               const char *func /* may be 0 */,
> -             char *fmt, va_list al)
> +             const char *fmt, va_list al)
>       __attribute__((format(printf,7,0)));
>  
>  _hidden void libxl__log(libxl_ctx *ctx, xentoollog_level msglevel, int 
> errnoval,
>              const char *file /* may be 0 */, int line /* ignored if !file */,
>              const char *func /* may be 0 */,
> -            char *fmt, ...)
> +            const char *fmt, ...)
>       __attribute__((format(printf,7,8)));
>  
>       /* these functions preserve errno (saving and restoring) */



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>