Re: [Xen-devel] [PATCH v2] libxl: Provide a version of bsd's queue.h as _libxl_list.h

[Anil Madhavapeddy <anil@xxxxxxxxxx>]

On 27 Oct 2011, at 18:08, Ian Jackson wrote:

> We would like some linked list macros which are (a) well known to be
> sane and (b) typesafe.  BSD's queue.h meets these criteria.
> 
> We also provide some simple perlery to arrange to add the libxl_
> namespace prefix to the macros.  This will allow us to #include
> _libxl_list.h in our public header file without clashing with anyone
> else who is also using another version of queue.h.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> ---
> 
> Changes since v1:
>   - use move-if-changed to install _libxl_list.h
>   - mention bsd-queue.3's 4-clause BSD licence in COPYING
>   - explictly call the perl script from the Makefile with "perl"
>   - move the imported files into external/ and provide a README there
>   - sed out the include of sys/cdefs.h
>   - improved commit message
> 
> 
> COPYING                              |    8 +
> tools/libxl/Makefile                 |   10 +-
> tools/libxl/bsd-sys-queue-h-seddery  |   70 +++
> tools/libxl/external/README          |   13 +
> tools/libxl/external/bsd-queue.3     | 1044 ++++++++++++++++++++++++++++++++++
> tools/libxl/external/bsd-sys-queue.h |  637 +++++++++++++++++++++
> 6 files changed, 1779 insertions(+), 3 deletions(-)
> 
> diff --git a/COPYING b/COPYING
> index 07535ad..524542d 100644
> --- a/COPYING
> +++ b/COPYING
> @@ -18,6 +18,14 @@ GPLv2. See the FSF's definition of GPL compatibility:
> And how this applies to a range of open source licenses:
>  http://www.gnu.org/licenses/license-list.html
> 
> +Additionally, the documentation file tools/libxl/external/bsd-queue.3
> +has the 4-clause BSD licence.  It is present in the Xen source tree
> +for reference purposes for people developing Xen.  It is not installed
> +by "make install" and is bundled in the source only for convenience of
> +distribution.  We do not intend that we or Xen users or distributors
> +should make any reference to "features or use" of that manpage.

FWIW, the advertising clause was rescinded by Berkeley about 12 years ago and 
can be removed from their code. OpenBSD did this in queue.3 in:

Author: Todd C. Miller <millert@xxxxxxxxxxx>
Date:   Mon Jun 2 23:32:09 2003 +0000

    Remove the advertising clause in the UCB license which Berkeley
    rescinded 22 July 1999.  Proofed by myself and Theo.

...so you may want to grab that version for simplicity. I'm not sure why 
FreeBSD hasn't removed it.

-anil


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel