WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH 46/49] xen: irq: Remove IRQF_DISABLED

To: linux-kernel@xxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH 46/49] xen: irq: Remove IRQF_DISABLED
From: Yong Zhang <yong.zhang0@xxxxxxxxx>
Date: Sat, 22 Oct 2011 17:56:58 +0800
Cc: tglx@xxxxxxxxxxxxx, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Sat, 22 Oct 2011 03:19:20 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=RJnEkGMwWWKY5I9YMcMlN3SWRjuZIckm91FDnoXVbXc=; b=yAt4ot7Nk645V5uvTj63Mp0Lx8r/5Q10wzohbYzc2Hbk10qmR9ziTWKdnb2XXG/tl0 nKfXCBUeCdyWT6fkYh2CEbdqREbGP64u9ezqZ/2kOGBWToZrfyfo1xLVp6SJlULWdDl/ AZUiAFg/9n9V47PRYwS0Wc2SMLO/Ojm61QWFY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1319277421-9203-1-git-send-email-yong.zhang0@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1319277421-9203-1-git-send-email-yong.zhang0@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

Signed-off-by: Yong Zhang <yong.zhang0@xxxxxxxxx>
---
 drivers/xen/evtchn.c       |    2 +-
 drivers/xen/platform-pci.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c
index dbc13e9..95e2507 100644
--- a/drivers/xen/evtchn.c
+++ b/drivers/xen/evtchn.c
@@ -265,7 +265,7 @@ static int evtchn_bind_to_user(struct per_user_data *u, int 
port)
        set_port_user(port, u);
        set_port_enabled(port, true); /* start enabled */
 
-       rc = bind_evtchn_to_irqhandler(port, evtchn_interrupt, IRQF_DISABLED,
+       rc = bind_evtchn_to_irqhandler(port, evtchn_interrupt, 0,
                                       u->name, (void *)(unsigned long)port);
        if (rc >= 0)
                rc = 0;
diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
index 319dd0a..482beff 100644
--- a/drivers/xen/platform-pci.c
+++ b/drivers/xen/platform-pci.c
@@ -84,7 +84,7 @@ static irqreturn_t do_hvm_evtchn_intr(int irq, void *dev_id)
 static int xen_allocate_irq(struct pci_dev *pdev)
 {
        return request_irq(pdev->irq, do_hvm_evtchn_intr,
-                       IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TRIGGER_RISING,
+                       IRQF_NOBALANCING | IRQF_TRIGGER_RISING,
                        "xen-platform-pci", pdev);
 }
 
-- 
1.7.1


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH 46/49] xen: irq: Remove IRQF_DISABLED, Yong Zhang <=