 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH 18 of 27 v3] libxl: merge libxl__device_del into
| To: | Ian Campbell <Ian.Campbell@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH 18 of 27 v3] libxl: merge libxl__device_del into libxl__device_remove |
| From: | Roger Pau Monné <roger.pau@xxxxxxxxxxxxx> |
| Date: | Wed, 19 Oct 2011 12:42:00 +0200 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
| Delivery-date: | Wed, 19 Oct 2011 03:42:33 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=DQwE6D2zeO3Zpt6x4yq3rSFOgmTPx9RdZtff8mCQiM4=; b=ic5MXakmLLEfQiwQWveEZYXuDYR2cMMOKkbxY/6bPzjCvhePh0ZsvjDvQ+FQIPvM2q R7jGGMCV1ODF1l7OCcfuiRs3wXovtD6uvB7iThAqvys+sGQoDD1wr+BR7ZUZmA+CVqXL DQGm9cKPyNGbvysXhrNq1Pr4D4rCsiA70qa94= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <1319020562.3385.96.camel@xxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <patchbomb.1318942495@xxxxxxxxxxxxxxxxxxxxxxxxx> <4020531a53fcb1a5579d.1318942513@xxxxxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK7+ZdHWvp_92bCjqUzOTYU=_4JH20iYvToXihbH6MoDUA@xxxxxxxxxxxxxx> <1319020562.3385.96.camel@xxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
2011/10/19 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> On Wed, 2011-10-19 at 11:22 +0100, Roger Pau Monné wrote:
>> > + xs_watch(ctx->xsh, state_path, be_path);
>> > + libxl__device_destroy_tapdisk(gc, be_path);
>> > +
>> > + if (wait) {
>> > + struct timeval tv;
>> > + tv.tv_sec = LIBXL_DESTROY_TIMEOUT;
>> > + tv.tv_usec = 0;
>> > + (void)wait_for_dev_destroy(gc, &tv);
>>
>> I think we should check the return value of wait_for_dev_destroy here,
>> since it might timeout, and the device is not removed then, so
>> libxl__device_remove should return 1 in that case (whereas it always
>> returns 0 now in that case, even when the device is still being
>> watched).
>
> Sure, didn't you post such a patch recently?
Yes, it was for the old version of your series and also included the
fix for libxl__device_remove always returning 0, I will modify it to
strip the now unnecessary parts and repost.
> Ian.
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| Previous by Date: | Re: [Xen-devel] [PATCH 1/5] xen/netback: Use xenballooned pages for comms, David Vrabel |
|---|---|
| Next by Date: | [Xen-devel] [PATCH v5] libxl: reimplement buffer for bootloading and drop data if buffer is full, Roger Pau Monne |
| Previous by Thread: | Re: [Xen-devel] [PATCH 18 of 27 v3] libxl: merge libxl__device_del into libxl__device_remove, Ian Campbell |
| Next by Thread: | [Xen-devel] [PATCH 20 of 27 v3] libxl: convert disk handling to device API, Ian Campbell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
