Re: [Xen-devel] RFC: Partially revert xen-unstable c/s 23071:a3466b005017

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Tue, Oct 18, 2011 at 3:11 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> The use of "hard-link" here is confusing. You presumably mean it bakes
> the literal/precise path into the binary.

Yes; it hard-codes the full path of the build tree library file.

> Nowadays this expands to:
>        $(XEN_LIBXC)/libxenctrl.so $(XEN_LIBXC)/libxenguest.so
> prior to 23921:19d2922bcfb9 it would have been:
>        -L$(XEN_LIBXC) -lxenctrl -L$(XEN_LIBXC) -lxenguest
>
> which tree were you working against?

Not sure what you're asking; this is XenServer trunk, with the xen.hg
pulled in from xen-unstable (pulled recently, like Friday or
something).

> Are you sure 23071:a3466b005017 and not 23921:19d2922bcfb9 is to blame?
> The <23931 version doesn't seem materially different to the <21071 one
> whereas I can plausibly imagine that 23931 might have made a difference.

You're right, it's actually 23921 that caused the problem.  I just did
"hg annotate" and found 23071.

> -ccopt just passes the raw argument in and seems likely to be more
> correct (irrespective of any of the changesets mentioned here, since the
> variable seems to have always included -L and -l itself). Perhaps that
> helps?

Sorry, I'm having trouble mentally compling this paragraph into patch.
:-)  (In part no doubt because I don't understand the make syntax you
mention.)  Could you explain what you mean?

Thanks,
 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel