WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] hvmloader: Don't set hpet->header.length twice

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] hvmloader: Don't set hpet->header.length twice
From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Date: Fri, 14 Oct 2011 16:15:19 +0100
Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Delivery-date: Fri, 14 Oct 2011 08:16:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.4.3
It is redundant.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

diff -r 4b0907c6a08c -r a112f0afefc7 tools/firmware/hvmloader/acpi/build.c
--- a/tools/firmware/hvmloader/acpi/build.c     Tue Oct 11 12:02:58 2011 +0100
+++ b/tools/firmware/hvmloader/acpi/build.c     Fri Oct 14 16:14:26 2011 +0100
@@ -186,8 +186,7 @@ static struct acpi_20_hpet *construct_hp
     hpet->addr.address        = ACPI_HPET_ADDRESS;
 
     hpet->header.length = sizeof(*hpet);
-    set_checksum(hpet, offsetof(struct acpi_header, checksum),
-                 hpet->header.length = sizeof(*hpet));
+    set_checksum(hpet, offsetof(struct acpi_header, checksum), sizeof(*hpet));
     return hpet;
 }
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] hvmloader: Don't set hpet->header.length twice, Andrew Cooper <=