xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] check for 'flex' before starting tools build

from [Jan Beulich]

[Permanent Link][Original]

To:	"Olaf Hering" <olaf@xxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] check for 'flex' before starting tools build
From:	"Jan Beulich" <JBeulich@xxxxxxxx>
Date:	Tue, 11 Oct 2011 14:03:50 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 11 Oct 2011 06:09:36 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<20111011121917.GA6381@xxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<5a5181b8c31983ff2f46.1318335064@xxxxxxxxxxxx> <20111011121917.GA6381@xxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

>>> On 11.10.11 at 14:19, Olaf Hering <olaf@xxxxxxxxx> wrote:
> On Tue, Oct 11, Olaf Hering wrote:
> 
>> # HG changeset patch
>> # User Olaf Hering <olaf@xxxxxxxxx>
>> # Date 1318335031 -7200
>> # Node ID 5a5181b8c31983ff2f465f85a41df784a5397ed5
>> # Parent  4b0907c6a08c348962bd976c2976257b412408be
>> check for 'flex' before starting tools build.
> 
> A similar check should be added for bison.
> 
> After todays 'hg pull -u' and 'make tools xen', two files were modified:
> 
>  # hg st
> M tools/libxl/libxlu_disk_l.c
> M tools/libxl/libxlu_disk_l.h
> 
> Shouldnt they be generated files in the first place,
> and not part of the SCM?

Correct - this had happened once already. And neither flex nor
bison should be required (or if they were, likely a minimum version
would also need to be enforced, and the overridable $(FLEX) and
$(BISON) values would also need to be taken into consideration -
when this happened first, I had to use privately built variants on
SLE10 for things to work out properly).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] check for 'flex' before starting tools build, Olaf Hering Re: [Xen-devel] [PATCH] check for 'flex' before starting tools build, Olaf Hering Re: [Xen-devel] [PATCH] check for 'flex' before starting tools build, Jan Beulich <=

Previous by Date:	Re: [Xen-devel] RE: [PATCH 02 of 23] libxl: add a comment describing the device interfaces, Roger Pau Monné
Next by Date:	Re: [Xen-devel] why xen use x86_emulation() in page_fault, cc Luit
Previous by Thread:	Re: [Xen-devel] [PATCH] check for 'flex' before starting tools build, Olaf Hering
Next by Thread:	[Xen-devel] [PATCH] libxl: reimplement buffer for bootloading and drop data if buffer is full, Roger Pau Monne
Indexes:	[Date] [Thread] [Top] [All Lists]