WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2 of 2] build: append YAJL_CLFAGS and YAJL_LDFLAG

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 2] build: append YAJL_CLFAGS and YAJL_LDFLAGS to libxl build
From: Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>
Date: Mon, 10 Oct 2011 10:23:34 +0200
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 10 Oct 2011 01:24:16 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=QBrctaK0X8jjeqOBQtP4SAfexf03lh8PlCLGEQUNk1k=; b=d5Fe9ALwVEZiEz1cmMuq3If5VC5I+AlsN5O/+jcfiqYat2v4CiIMoarPXxYAq86xhE p8wZqGLB1oboVg+ZoVfhOclxqio1SXIT3I1OSC40aur9lSXWguLqDxatwrwJjy+NvTMn gZ/58KQE3/zV7bFpjSunqzUE0my5+OSxPpSwA=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110.63052.985985.409587@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1317900424@loki> <dd09f32c882c9e1492b2.1317900426@loki> <20109.61822.25684.330705@xxxxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK4O0ai0EwGiCfuh8k3wk9mw8H5H-vs3N70tjnf5dWkmnw@xxxxxxxxxxxxxx> <20110.63052.985985.409587@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> Ah.  I don't think the approach of only using these flags when
> compiling libxl is a good one, then, as it would build libxl against
> these putative old Xen headers.
>
> I think the problem then is that the ordering of the various -I and -L
> options is wrong.  The EXTRA_* should come near the end, after all of
> the -I and -L specified by the build system to refer to other parts of
> the Xen tree.
>
> Would you like to look into how to make that work :-) ?

I've took a look at how EXTRA_LIB and EXTRA_INCLUDES are handled, and
found that they are appended to CFLAGS and LDFLAGS, so it's mostly the
same using CFLAGS or EXTRA_INCLUDES. The best way I've come up to
solve this is to modify each makefile and append EXTRA_LIB and
EXTRA_INCLUDES at the end, but this means modifying a lot of
makefiles. What do you think?

Regards, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel