RE: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

["Kay, Allen M" <allen.m.kay@xxxxxxxxx>]

Hi Juergen,

 

This patch fixes the build problem for xen-unstable but do not apply to xen-4.1-testing.  Xen-4.1-testing do not have xfs directory and still has the same build error.

 

Allen

 

From: Juergen Gross [mailto:juergen.gross@xxxxxxxxxxxxxx]
Sent: Wednesday, October 05, 2011 9:41 PM
To: Kay, Allen M
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; keir@xxxxxxx
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

 

Hi Allen,

On 10/05/2011 06:24 PM, Kay, Allen M wrote:

> This is fixed with cs 23049 in xen-unstable:

>

> http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html

 

I’m using the latest staging tree (cs# 23903) and still seeing this problem.

Uuh, the same bug was introduced again.
Could you try the following patch:

diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
--- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:18:30 2011 +0200
+++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:32:00 2011 +0200
@@ -1,4 +1,4 @@ XEN_ROOT = ../../..
-XEN_ROOT = ../../..
+XEN_ROOT = $(CURDIR)/../../..
 
 LIB_SRCS-y = fsys_xfs.c
 

Keir, it is easy to catch this problem: create a .config file in all directories
_above_ $XEN_ROOT containing something like:

$(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))


Juergen

 

Allen

 

 

From: Juergen Gross [mailto:juergen.gross@xxxxxxxxxxxxxx]
Sent: Tuesday, October 04, 2011 9:45 PM
To: Kay, Allen M
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; keir@xxxxxxx
Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

 

On 10/04/2011 11:44 PM, Kay, Allen M wrote:

Hi Keir,

 

I’m getting the following build error caused by “-include $(XEN_ROOT)/.config” line in Config.mk.  Removing it from Config.mk makes the error go away.  The OS I’m using is FC15.  “$(XEN_ROOT)/.config” does not exist.

 

Allen

 

-------

 

make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'

make[4]: *** ../../.config: Is a directory.  Stop.

make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'

make[3]: *** [subdir-clean-check] Error 2

make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'

make[2]: *** [subdirs-clean] Error 2

make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'

make[1]: *** [clean] Error 2

make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'

make: *** [world] Error 2

 

This is fixed with cs 23049 in xen-unstable:

http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html


Juergen

-- 

Juergen Gross                 Principal Developer Operating Systems

PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967

Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx

Domagkstr. 28                           Internet: ts.fujitsu.com

D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________

Xen-devel mailing list

Xen-devel@xxxxxxxxxxxxxxxxxxx

http://lists.xensource.com/xen-devel

-- 

Juergen Gross                 Principal Developer Operating Systems

PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967

Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx

Domagkstr. 28                           Internet: ts.fujitsu.com

D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel