WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xenbus: Fix loopback event channel assuming doma

To: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xenbus: Fix loopback event channel assuming domain 0
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Thu, 6 Oct 2011 18:53:32 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 06 Oct 2011 10:54:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1317824920-639-1-git-send-email-dgdegra@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <1317824920-639-1-git-send-email-dgdegra@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Daniel De Graaf writes ("[Xen-devel] [PATCH] xenbus: Fix loopback event channel 
assuming domain 0"):
> The xenbus event channel established in xenbus_init is intended to be a
> loopback channel, but the remote domain was hardcoded to 0; this will
> cause the channel to be unusable when xenstore is not being run in
> domain 0.

I'm not sure I understand this.

...
>               /* Next allocate a local port which xenstored can bind to */
>               alloc_unbound.dom        = DOMID_SELF;
> -             alloc_unbound.remote_dom = 0;
> +             alloc_unbound.remote_dom = DOMID_SELF;

The comment doesn't suggest that this is supposedly a loopback channel
(ie one for use by the xenbus client for signalling to itself,
somehow).

Rather it's supposed to be a channel to xenstore.  So the remote
domain should be the xenstore domain, which should come from the
shared info page.

Have you actually tested this with a separate xenstored domain ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel