Re: [Xen-devel] Re: [PATCH 0 of 9] Call hotplug scripts from libxl

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Tue, 2011-10-04 at 15:15 +0100, Roger Pau Monné wrote:
> 2011/10/4 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> > By default xl daemonises itself and monitors the domain waiting for it
> > to exit, at which point it should perform the necessary cleanup (this is
> > the call to libxl_domain_destroy in handle_domain_death).
> 
> libxl daemonises itself if you call "xl shutdown <domain>", but if the
> domain shuts down from inside (doing a "halt"), xl is never called,
> and therefore hotplug scripts are not executed.

I don't think "xl shutdown" daemonises ever. 

"xl create" daemonises itself and waits for the guest to die. It should
be detecting the guest shutdown no matter if it is triggered internally
or externally. That's not to say it's not buggy though...


> 
> > If you ask xl to not do this (using the -e or -F options) then you are
> > expected to call xl destroy yourself.
> >
> > The call to libxl_domain_destroy calls libxl__devices_destroy which
> > tears down the backends. Unfortunately this is done in a slightly
> > generic way but my recent series should have laid the ground work for
> > doing this in a more device-specific way.
> >
> > I have a feeling that libxl__device_destroy should really consist of a
> > sequence of libxl_device_FOO_list+foreach(thing) libxl_device_FOO_remove
> > calls rather than the current mechanism. i.e. be really explicit about
> > what it is tearing down.
> >
> > Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel