Re: [Xen-devel] [PATCH 1/3] xen/pv-on-hvm kexec: prevent crash i

To:	Ian Campbell <Ian.Campbell@xxxxxxxxxx>, Keir Fraser <keir.xen@xxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 1/3] xen/pv-on-hvm kexec: prevent crash in xenwatch_thread() when stale watch events arrive
From:	Olaf Hering <olaf@xxxxxxxxx>
Date:	Wed, 17 Aug 2011 14:51:27 +0200
Cc:	Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Konrad <konrad.wilk@xxxxxxxxxx>
Delivery-date:	Wed, 17 Aug 2011 05:53:31 -0700
Dkim-signature:	v=1; a=rsa-sha1; c=relaxed/relaxed; t=1313585550; l=1097; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=aQ/9M4Nz0i7NGiq2S7r+9l5OSgM=; b=uhr4iWDEF21cBrBZCMj0BQQOD10y49259kk/mm5VXvrZOnW5VakcHwOIfel1wb0w8fg 5ZCQVg1MrJhjgNcJ9Ad1K0FVnfd3OJlRsHJs330s5L61Mti5HEbT+zrtLAx3Sr5IjnpD9 e8aJV3c0ls7fhGmbQ9MDWq8cLo7xuq/a8z8=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<1313504072.5010.120.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<1313500613-21394-1-git-send-email-olaf@xxxxxxxxx> <1313500613-21394-2-git-send-email-olaf@xxxxxxxxx> <1313504072.5010.120.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.21.rev5535 (2011-07-01)

On Tue, Aug 16, Ian Campbell wrote:

> On Tue, 2011-08-16 at 14:16 +0100, Olaf Hering wrote:
> > During repeated kexec boots xenwatch_thread() can crash because
> > xenbus_watch->callback is cleared by xenbus_watch_path() if a node/token
> > combo for a new watch happens to match an already registered watch from
> > an old kernel.  In this case xs_watch returns -EEXISTS, then
> > register_xenbus_watch() does not remove the to-be-registered watch from
> > the list of active watches but returns the -EEXISTS to the caller
> > anyway.
> 
> Isn't this behaviour the root cause of the issue (which should be fixed)
> rather than papering over it during watch processing. IOW should't
> register_xenbus_watch cleanup after itself if xs_watch fails.

Keir, the EEXISTS case in register_xenbus_watch() was added by you 6
years ago. Do you happen to know what it tried to solve, and do these
conditions still apply today?  Perhaps the EEXISTS can be removed now.

http://xenbits.xen.org/hg/xen-unstable.hg/diff/8016551fde98/linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_xs.c

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 1/3] xen/pv-on-hvm kexec: prevent crash in xenwat