WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
From: Steven Rostedt <rostedt@xxxxxxxxxxx>
Date: Mon, 08 Aug 2011 09:01:07 -0400
Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, linux-next@xxxxxxxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Linus, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 08 Aug 2011 06:02:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E3D8657.7000704@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110725162542.39ea8d8cbd51604523635c1a@xxxxxxxxxxxxxxxx> <20110725144629.b752bf14.rdunlap@xxxxxxxxxxxx> <20110804193534.GB12729@xxxxxxx> <20110804195539.GA11198@xxxxxxxxxxxx> <20110804131516.c4da6595.rdunlap@xxxxxxxxxxxx> <20110804223259.GB4370@xxxxxxxxxxxx> <20110804224020.GA21492@xxxxxxxxxxxx> <4E3B3117.5050308@xxxxxxxxxxxx> <20110805080531.GA8052@xxxxxxx> <20110805211423.GA9765@xxxxxxx> <20110806015815.GA26833@xxxxxxxxxxxx> <4E3D8657.7000704@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sat, 2011-08-06 at 11:22 -0700, Jeremy Fitzhardinge wrote:
> On 08/05/2011 06:58 PM, Konrad Rzeszutek Wilk wrote:
> > On Fri, Aug 05, 2011 at 11:14:23PM +0200, Ingo Molnar wrote:
> >> * Ingo Molnar <mingo@xxxxxxx> wrote:
> >>
> >>> * Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> >>>
> >>>> On 08/04/11 15:40, Konrad Rzeszutek Wilk wrote:
> >>>>> On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote:
> >>>>>>>>> These build failures are still triggering upstream:
> >>>>>>>>>
> >>>>>>>>>  arch/x86/xen/trace.c:44:2: error: array index in initializer not 
> >>>>>>>>> of integer type
> >>>>>>>>>  arch/x86/xen/trace.c:44:2: error: (near initialization for 
> >>>>>>>>> ‘xen_hypercall_names’)
> >>>>>>>>>  arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared 
> >>>>>>>>> here (not in a function)
> >>>>>>>>>  arch/x86/xen/trace.c:45:2: error: array index in initializer not 
> >>>>>>>>> of integer type
> >>>>>>>>>  arch/x86/xen/trace.c:45:2: error: (near initialization for 
> >>>>>>>>> ‘xen_hypercall_names’)
> >>>>>>>> Oh, that I haven't seen. Can you send me the .config for that please.
> >>>>>>> You can't be trying very hard then.  I see lots of these (but no,
> >>>>>> Ah, I am getting it now. Thanks for reporting it.
> >>>>> This should do the trick:
> >>>> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> >>> That patch did the trick here too:
> >>>
> >>> Acked-by: Ingo Molnar <mingo@xxxxxxx>
> >> Except that i'm still seeing the occasional build failure - see the 
> >> error log below. Config attached.
> > Much appreciate for the report. I believe this fix (which I think hit
> > linux-next yesterday?) should do that:
> >
> > commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd
> > Author: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
> > Date:   Wed Aug 3 09:43:44 2011 -0700
> >
> >      xen/tracing: it looks like we wanted CONFIG_FTRACE
> >     
> >     Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_TRACER.
> >     
> >     Reported-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
> >     Tested-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
> >     Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> >     Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> >
> > diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
> > index 45e94ac..3326204 100644
> > --- a/arch/x86/xen/Makefile
> > +++ b/arch/x86/xen/Makefile
> > @@ -15,7 +15,7 @@ obj-y             := enlighten.o setup.o multicalls.o 
> > mmu.o irq.o \
> >                     grant-table.o suspend.o platform-pci-unplug.o \
> >                     p2m.o
> >  
> > -obj-$(CONFIG_FUNCTION_TRACER) += trace.o
> > +obj-$(CONFIG_FTRACE) += trace.o
> >  
> 
> I'm not sure this is correct either.  Maybe it should be
> CONFIG_TRACEPOINTS?  Steven?

Actually, I believe the correct answer is:

CONFIG_EVENT_TRACING

-- Steve



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel