WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)

To: Ingo Molnar <mingo@xxxxxxx>
Subject: Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Thu, 4 Aug 2011 15:55:39 -0400
Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Randy Dunlap <rdunlap@xxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, linux-next@xxxxxxxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Delivery-date: Thu, 04 Aug 2011 12:59:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110804193534.GB12729@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110725162542.39ea8d8cbd51604523635c1a@xxxxxxxxxxxxxxxx> <20110725144629.b752bf14.rdunlap@xxxxxxxxxxxx> <20110804193534.GB12729@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Aug 04, 2011 at 09:35:34PM +0200, Ingo Molnar wrote:
> 
> * Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> 
> > On Mon, 25 Jul 2011 16:25:42 +1000 Stephen Rothwell wrote:
> > 
> > > Hi all,
> > 
> > xen has lots of build errors and warnings (all on x86_64).

Hm, I have a fix in my linux-next (and stable/bug.fixes) for this that I was 
thinking
to send in a couple of days ..


commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd
Author: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date:   Wed Aug 3 09:43:44 2011 -0700

     xen/tracing: it looks like we wanted CONFIG_FTRACE
    
    Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_TRACER.
    
    Reported-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
    Tested-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
    Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
index 45e94ac..3326204 100644
--- a/arch/x86/xen/Makefile
+++ b/arch/x86/xen/Makefile
@@ -15,7 +15,7 @@ obj-y         := enlighten.o setup.o multicalls.o mmu.o irq.o 
\
                        grant-table.o suspend.o platform-pci-unplug.o \
                        p2m.o
 
-obj-$(CONFIG_FUNCTION_TRACER) += trace.o
+obj-$(CONFIG_FTRACE) += trace.o
 
 obj-$(CONFIG_SMP)              += smp.o
 obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= spinlock.o

.. snip of the long compile error..

> These build failures are still triggering upstream:
> 
>  arch/x86/xen/trace.c:44:2: error: array index in initializer not of integer 
> type
>  arch/x86/xen/trace.c:44:2: error: (near initialization for 
> ‘xen_hypercall_names’)
>  arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared here (not 
> in a function)
>  arch/x86/xen/trace.c:45:2: error: array index in initializer not of integer 
> type
>  arch/x86/xen/trace.c:45:2: error: (near initialization for 
> ‘xen_hypercall_names’)

Oh, that I haven't seen. Can you send me the .config for that please.

> 
> even after:
> 
>  b3c4b9825075: xen/tracing: fix compile errors when tracing is disabled.
> 
> Btw., that the heck is going on with the commit that introduced the 
> build failure:
> 
>  commit bd9ddc875b6659f9f74dcfd285c472bc58041abd
>  Author:     Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
>  AuthorDate: Mon Jun 20 17:52:13 2011 -0700
>  Commit:     Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
>  CommitDate: Mon Jul 18 15:43:46 2011 -0700
> 
> It was apparently rebased shortly before the merge window and sent to 

Well, the rebase I get - it was done on top of the merge that introduced
the new functionality.

> Linus 3 days later, with little to no linux-next testing ...

<Hmm> It did fix the compile problem.. albeit it created another one.
> 
> I'm absolutely unhappy about how the Xen tree is being run. It's 
> using a sloppy, crappy workflow and it is producing crap.

Do you have a manual of how you guys run your workflow?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel