WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Qemu-devel] [PATCH] xen: Avoid useless allocation in Xe

To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH] xen: Avoid useless allocation in Xen case.
From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
Date: Tue, 02 Aug 2011 14:49:33 +0200
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Alexander Graf <agraf@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, QEMU-devel <qemu-devel@xxxxxxxxxx>
Delivery-date: Tue, 02 Aug 2011 05:50:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CAJJyHjJUCz4Ce+oY34JAHg5FZrvy5p+o6+8fd09z076HcS=f1g@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1312226782-26882-1-git-send-email-anthony.perard@xxxxxxxxxx> <4E37052E.70707@xxxxxx> <4E37D621.3050302@xxxxxxxxxxx> <CAJJyHjJUCz4Ce+oY34JAHg5FZrvy5p+o6+8fd09z076HcS=f1g@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666
On 2011-08-02 14:13, Anthony PERARD wrote:
> On Tue, Aug 2, 2011 at 11:49, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
>>> The same applies to kvm, please generalize.
>>
>> Actually, qemu-kvm avoids this overhead today by making code_gen_alloc
>> return immediately when kvm is on. Also not very beautiful.
>>
>> Can't we simply skip cpu_exec_init_all for any accel != TCG, e.g. by
>> moving that call to tcg_init?
> 
> In the function cpu_exec_init_all(), the call to cpu_gen_init() (and I
> suppose to io_mem_init()) is still required. So we can not move the
> whole function to tcg_init().
> 
> But I can maybe use "if (!tcg_enabled())" instead of a check to xen.
> Until no tcg code is use when kvm/xen is enabled.

I would prefer to take the chance and clean up. Anything TCG related
belongs to tcg_init (or a function called from it). Shared services
should be initialized as before. Will send a patch to make a start.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>