| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH v3] xen: implement unplug protocol in xen_platfor
|
To: |
Kevin Wolf <kwolf@xxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH v3] xen: implement unplug protocol in xen_platform |
|
From: |
Alexander Graf <agraf@xxxxxxx> |
|
Date: |
Thu, 30 Jun 2011 14:14:14 +0200 |
|
Cc: |
xen-devel@xxxxxxxxxxxxxxxxxxx, mst@xxxxxxxxxx, stefano.stabellini@xxxxxxxxxxxxx, qemu-devel@xxxxxxxxxx, armbru@xxxxxxxxxx, anthony@xxxxxxxxxxxxx, anthony.perard@xxxxxxxxxx |
|
Delivery-date: |
Thu, 30 Jun 2011 05:15:25 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<4E0C6905.2040604@xxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<1309260558-3332-1-git-send-email-stefano.stabellini@xxxxxxxxxxxxx> <4E0C61DF.2050606@xxxxxxx> <4E0C6905.2040604@xxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8 |
On 06/30/2011 02:16 PM, Kevin Wolf wrote:
Am 30.06.2011 13:45, schrieb Alexander Graf:
On 06/28/2011 01:29 PM, stefano.stabellini@xxxxxxxxxxxxx wrote:
From: Stefano Stabellini<stefano.stabellini@xxxxxxxxxxxxx>
The unplug protocol is necessary to support PV drivers in the guest: the
drivers expect to be able to "unplug" emulated disks and nics before
initializing the Xen PV interfaces.
It is responsibility of the guest to make sure that the unplug is done
before the emulated devices or the PV interface start to be used.
We use pci_for_each_device to walk the PCI bus, identify the devices and
disks that we want to disable and dynamically unplug them.
$ ~/git/qemu/scripts/checkpatch.pl *
ERROR: space required after that ',' (ctx:VxV)
#158: FILE: hw/ide/piix.c:240:
+ },{
^
total: 1 errors, 0 warnings, 130 lines checked
I think checkpatch.pl should be fixed in this case. We do have this
pattern all over the place in qemu and I don't see why it's bad.
Hrm. I tend to agree. I'll post a patch :).
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home