[Xen-devel] [PATCH] libxl: correct allocation size in libxl_list_nics

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1308843248 -3600
# Node ID 18476e67178555b92b9bf893a3c550a9095caef8
# Parent  13048e166ab661e32269cd3abf8737a52e6229dd
libxl: correct allocation size in libxl_list_nics

The function returns a list of libxl_nicinfo not libxl_device_nic.

Causes memory corruption on free.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 13048e166ab6 -r 18476e671785 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Thu Jun 23 15:26:59 2011 +0100
+++ b/tools/libxl/libxl.c       Thu Jun 23 16:34:08 2011 +0100
@@ -1356,7 +1356,7 @@ libxl_nicinfo *libxl_list_nics(libxl_ctx
                            libxl__sprintf(&gc, "%s/device/vif", dompath), 
&nb_nics);
     if (!l)
         goto err;
-    nics = res = calloc(nb_nics, sizeof (libxl_device_nic));
+    nics = res = calloc(nb_nics, sizeof (libxl_nicinfo));
     if (!res)
         goto err;
     for (*nb = nb_nics; nb_nics > 0; --nb_nics, ++l, ++nics) {

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel