WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/

Home

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing

from [Shriram Rajagopalan]

[Permanent Link][Original]

To:	Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer
From:	Shriram Rajagopalan <rshriram@xxxxxxxxx>
Date:	Tue, 21 Jun 2011 14:43:39 -0400
Cc:	Brendan Cully <brendan@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 21 Jun 2011 11:45:16 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<19968.53138.564453.916057@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<patchbomb.1307361109@xxxxxxxxxxxxxxxxxxx> <0af6803eeb9f278abd17.1307361112@xxxxxxxxxxxxxxxxxxx> <B9E1AECF-165E-4732-B852-84893DD10EEC@xxxxxxxxx> <19968.53138.564453.916057@xxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	rshriram@xxxxxxxxx
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Tue, Jun 21, 2011 at 1:06 PM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:

Brendan Cully writes ("Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer"):

> Bare except clauses are bad style. Please only handle the exact
> exceptions you are expecting.
>
> Nacked-by: Brendan Cully <brendan@xxxxxxxxx>

I agree. Shriram ?

Ian.

Yes, I ve been meaning to send out the revised version for a while. Will
send it out today.

shriram

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH 0 of 3] remus: cleanup python code, Shriram Rajagopalan [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer, Shriram Rajagopalan Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer, Brendan Cully Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer, Ian Jackson Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer, Shriram Rajagopalan <= [Xen-devel] [PATCH 2 of 3] remus: move makeheader from image.py to vm.py, Shriram Rajagopalan [Xen-devel] [PATCH 1 of 3] remus: remove dead code and unused modules, Shriram Rajagopalan

Previous by Date:	[Xen-devel] Re: [PATCH 1/3] x86: calculate precisely the memory needed by init_memory_mapping, H. Peter Anvin
Next by Date:	Re: [Xen-devel] Re: Konrad devel/next-3.0, pci-passthrough not working: Error: pci: PCI Backend and pci-stub don't own device, Sander Eikelenboom
Previous by Thread:	Re: [Xen-devel] [PATCH 3 of 3] remus: handle exceptions while installing/unstalling net buffer, Ian Jackson
Next by Thread:	[Xen-devel] [PATCH 2 of 3] remus: move makeheader from image.py to vm.py, Shriram Rajagopalan
Indexes:	[Date] [Thread] [Top] [All Lists]

This site is hosted by Citrix