WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH V4] libxl, Introduce a QMP client

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH V4] libxl, Introduce a QMP client
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Tue, 21 Jun 2011 14:33:48 +0100
Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 21 Jun 2011 06:34:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19967.24103.640384.969388@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1308324754-19159-1-git-send-email-anthony.perard@xxxxxxxxxx> <19967.24103.640384.969388@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2011-06-20 at 15:50 +0100, Ian Jackson wrote:
> 
> > +static struct {
> > +    const char *name;
> > +    message_type_e type;
> > +} member_name_to_message_type[] = {
> > +    { "QMP", QMP_QMP },
> > +    { "return", QMP_RETURN },
> > +    { "error", QMP_ERROR },
> > +    { "event", QMP_EVENT },
> > +    { "", QMP_ANY },
> > +};
> 
> If we do need to define these, we should use a libxl idl enum (with
> Ian Campbell's string-mapping-generation patch which I will apply
> shortly. 

Just to note that this is enum is only used internally, using the IDL as
is would make it public... It'd be relatively easy to allow for internal
types in the IDL but I'm not sure if we want to? I think if we did I'd
be tempted to add a separate libxl_internal.idl generating (using the
same generator) _libxl_types_internal.[ch] etc.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel