WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH 04 of 22] xenpaging: drop xc.c, remove ASSERT

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH 04 of 22] xenpaging: drop xc.c, remove ASSERT
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Fri, 10 Jun 2011 11:12:53 +0200
Delivery-date: Fri, 10 Jun 2011 02:18:53 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1307697178; l=1140; s=domk; d=aepfle.de; h=To:From:Date:References:In-Reply-To:Subject: Content-Transfer-Encoding:MIME-Version:Content-Type:X-RZG-CLASS-ID: X-RZG-AUTH; bh=CxwHF535KP/z+wNM5b3j0lN7BIk=; b=SSmBnfKa2Quq+9PQ17TkLnhH94rLEhibDyQdKNDZ03Ks0Ax0//qGj4dj+a3ZF7EuTQQ BSDzkRciazXglqEmVhZAgg7OEyMPEYpx11ZUc3UC5wwmgdF3FglKlmw2IQZZ4OQdx9IWW 3Gmomum9ubNedGBtOsJsmeTFGLs9/HyDEnk=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1307697169@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1307697169@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.7.5
# HG changeset patch
# User Olaf Hering <olaf@xxxxxxxxx>
# Date 1307695626 -7200
# Node ID 53623b8a03575e5e42a7e7d8eaf9020b4a3138f1
# Parent  2d2fe3e2bd73d0c257bb852ecb00052d0dcef301
xenpaging: drop xc.c, remove ASSERT

The ASSERT is not needed, victim is never NULL.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

diff -r 2d2fe3e2bd73 -r 53623b8a0357 tools/xenpaging/policy_default.c
--- a/tools/xenpaging/policy_default.c  Fri Jun 10 10:47:05 2011 +0200
+++ b/tools/xenpaging/policy_default.c  Fri Jun 10 10:47:06 2011 +0200
@@ -78,7 +78,6 @@ int policy_choose_victim(xenpaging_t *pa
 {
     xc_interface *xch = paging->xc_handle;
     unsigned long wrap = current_gfn;
-    ASSERT(victim != NULL);
 
     do
     {
diff -r 2d2fe3e2bd73 -r 53623b8a0357 tools/xenpaging/xc.h
--- a/tools/xenpaging/xc.h      Fri Jun 10 10:47:05 2011 +0200
+++ b/tools/xenpaging/xc.h      Fri Jun 10 10:47:06 2011 +0200
@@ -30,13 +30,6 @@
 #include <xen/mem_event.h>
 
 
-#if 1
-#define ASSERT(_p) \
-    if ( !(_p) ) { DPRINTF("Assertion '%s' failed, line %d, file %s", #_p , \
-    __LINE__, __FILE__); *(int*)0=0; }
-#else
-#define ASSERT(_p) ((void)0)
-#endif
 
 
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>