|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] [PATCH 11 of 12] xenpaging: add watch thread to catch gu
On Tue, Jun 07, Ian Campbell wrote:
> The correct way to watch for domain shutdown is to watch the special
> "@releaseDomain" node. IIRC this notifies you when _any_ domain has
> shutdown so you need to check for the domain you are actually interested
> in. Doing this also removes the need for the hacky extra xs_read_watch
> which you have -- which seems very racy to me and is almost certainly
> incorrect.
Thanks for the feedback, I have updated my patch to use this interface.
> Lastly I don't think you need a new thread for this, you can integrate
> the xs fd (from xs_fileno()) into your existing poll loop from
> xc_wait_for_event_or_timeout (which is a terrible name for a function
> which isn't in libxc, this should either be moved into the library or
> renamed depending on it's actual use cases. Same for the other xc_* in
> xenpaging...)
All of xc.c can be removed. If patches 1-10 are ok, can you apply them?
I will send another series to remove xc.c, which will also contain the
changes from patch 11 and 12.
Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
<Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [PATCH 01 of 12] xenpaging: correct dropping of pages to avoid full ring buffer, (continued)
- [Xen-devel] [PATCH 01 of 12] xenpaging: correct dropping of pages to avoid full ring buffer, Olaf Hering
- [Xen-devel] [PATCH 03 of 12] xenpaging: remove srand call, Olaf Hering
- [Xen-devel] [PATCH 04 of 12] xenpaging: remove return values from functions that can not fail, Olaf Hering
- [Xen-devel] [PATCH 05 of 12] xenpaging: catch xc_mem_paging_resume errors, Olaf Hering
- [Xen-devel] [PATCH 06 of 12] xenpaging: remove local domain_id variable, Olaf Hering
- [Xen-devel] [PATCH 08 of 12] xenpaging: start paging in the middle of gfn range, Olaf Hering
- [Xen-devel] [PATCH 07 of 12] xenpaging: move num_pages into xenpaging struct, Olaf Hering
- [Xen-devel] [PATCH 09 of 12] xenpaging: pass integer to xenpaging_populate_page, Olaf Hering
- [Xen-devel] [PATCH 11 of 12] xenpaging: add watch thread to catch guest shutdown, Olaf Hering
- [Xen-devel] [PATCH 10 of 12] xenpaging: add helper function for unlinking pagefile, Olaf Hering
- [Xen-devel] [PATCH 02 of 12] xenpaging: do not bounce p2mt to xenpaging, Olaf Hering
- [Xen-devel] [PATCH 12 of 12] xenpaging: implement stopping of pager by sending SIGTERM/SIGINT, Olaf Hering
- Re: [Xen-devel] [PATCH 00 of 12] xenpaging fixes for xen-unstable, Keir Fraser
|
|
|
|
|