WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 05 of 10] libxl: Set libxl_device_nic->domid when

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 05 of 10] libxl: Set libxl_device_nic->domid when looking up by devid
From: Marek Marczykowski <marmarek@xxxxxxxxxxxx>
Date: Sat, 04 Jun 2011 01:24:15 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 03 Jun 2011 16:25:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1307088696.775.301.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1307054130@devel14> <3e5e8eaf2fe8352e584e.1307054135@devel14> <1307088696.775.301.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.10
On 03.06.2011 10:11, Ian Campbell wrote:
> On Thu, 2011-06-02 at 23:35 +0100, Marek Marczykowski wrote:
>> # HG changeset patch
>> # User Marek Marczykowski <marmarek@xxxxxxxxxxxx>
>> # Date 1306962980 -7200
>> # Node ID 3e5e8eaf2fe8352e584e7498fde21d6e76c3475b
>> # Parent  df639d3eef683460b6d5ab38296cbd90b26f60f0
>> libxl: Set libxl_device_nic->domid when looking up by devid
>>
>> Fixes xl network-detach with device specified by id, not MAC
> 
> Please rebase onto xen-unstable.hg, the libxl_device_* structures no
> longer contain a domid in that tree, it is passed as a parameter to the
> relevant functions now.

Ok, but in 4.1 tree still domid field exists and is used. So this should
be fixed somehow (by applying this patch, or by backporting some other
patches from unstable)...

> 
> Ian.
> 
>>
>> Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxx>
>>
>> diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c
>> --- a/tools/libxl/libxl_utils.c
>> +++ b/tools/libxl/libxl_utils.c
>> @@ -512,6 +512,7 @@
>>      }
>>      nic->backend_domid = strtoul(val, NULL, 10);
>>      nic->devid = strtoul(devid, NULL, 10);
>> +    nic->domid = domid;
>>  
>>      val = libxl__xs_read(&gc, XBT_NULL, libxl__sprintf(&gc, "%s/mac", 
>> nic_path_fe));
>>      for (i = 0, tok = strtok(val, ":"); tok && (i < 6);
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
> 
> 


-- 
Pozdrawiam / Best Regards,
Marek Marczykowski         | RLU #390519
marmarek at mimuw edu pl   | xmpp:marmarek at staszic waw pl

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>