| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
RE: [Xen-devel] [PATCH v2] Enable SMEP CPU feature support for XEN hype
|
To: |
"Li, Xin" <xin.li@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>, "keir.xen@xxxxxxxxx" <keir.xen@xxxxxxxxx> |
|
Subject: |
RE: [Xen-devel] [PATCH v2] Enable SMEP CPU feature support for XEN hypervisor |
|
From: |
"Li, Xin" <xin.li@xxxxxxxxx> |
|
Date: |
Sat, 4 Jun 2011 01:09:31 +0800 |
|
Accept-language: |
zh-CN, en-US |
|
Acceptlanguage: |
zh-CN, en-US |
|
Cc: |
"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|
Delivery-date: |
Fri, 03 Jun 2011 10:17:08 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<FC2FB65B4D919844ADE4BE3C2BB739AD5AB9ECEF@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<4DE8FF730200007800070DFE@xxxxxxxxxxxxxxxxxx> <FC2FB65B4D919844ADE4BE3C2BB739AD5AB9ECEF@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
Acwh+57FspxslXpkSu2aRGDVnztYDQAByahQAAMtiOA= |
|
Thread-topic: |
[Xen-devel] [PATCH v2] Enable SMEP CPU feature support for XEN hypervisor |
> >+ if ( pf_type == smep_fault )
> >+ domain_crash_synchronous();
>
> >I don't think you can domain_crash_synchronous() here, domain_crash()
> >is perhaps the only possibility (and even if it was possible, I think there
> >was agreement to not add new calls to the former function and always
> >use the latter instead).
> >
>
> so change to domain_crash()?
>
> curious about the background how the agreement is reached?
>
We can't use domain_crash, or it causes system reboot as it returns to caller.
Actually I chose domain_crash_synchronous because it doesn't return back.
Or change pf_type to spurious_fault just before calling crash to avoid Xen
crash,
but looks ugly.
Thanks!
-Xin
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home