Re: [Xen-devel] [PATCH] libxl: Support linux-stubdom in libxl

To:	Jiageng Yu <yujiageng734@xxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] libxl: Support linux-stubdom in libxl
From:	Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date:	Wed, 1 Jun 2011 13:58:36 +0100
Cc:	Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, "Xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date:	Wed, 01 Jun 2011 06:05:31 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<BANLkTikCb2GEodgNCDyL9_qgfLE42hc+pA@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Citrix Systems, Inc.
References:	<BANLkTikCb2GEodgNCDyL9_qgfLE42hc+pA@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Tue, 2011-05-31 at 14:54 +0100, Jiageng Yu wrote:
> @@ -581,7 +589,12 @@
>          goto out;
>      }
> 
> -    args = libxl__build_device_model_args(gc, "stubdom-dm", info,
> +     if(libxl__is_linux_stubdom(info))

Please try and match the indentation level (incl tab vs spaces) of the
surrounding code.

You should probably checkout tools/libxl/CODING_STYLE.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] libxl: Support linux-stubdom in libxl