Re: [Xen-devel] [PATCH 2/2] libxc: enabling emulated MSI injection

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> >> +    hypercall.op     = __HYPERVISOR_hvm_op;
> >> +    hypercall.arg[0] = HVMOP_inj_msi;
> >> +    hypercall.arg[1] = HYPERCALL_BUFFER_AS_ARG(arg);
> >> +
> >> +    arg->domid = dom;
> >> +    arg->addr  = addr;
> >> +    arg->data  = data;
> >
> > Shouldn't those be done before you make the HYPERCALL_BUFFER_AS_ARG
> > in case they get bounced?
> >
> 
> Hmm... I didn't think that far.
> 
> I just copy-and-edit from a previous hypercall. I think that should be OK 
> then.

On a second look at the code, I believe you are right.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel