Re: [Xen-devel] [PATCH] Play with spice for xen-upstream-qemu on upstream Xen

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

ZhouPeng writes ("Re: [Xen-devel] [PATCH] Play with spice for xen-upstream-qemu 
on upstream Xen"):
> Resend the patch again with 3 fixes:

Thanks.  I was just about to apply this when I noticed a couple of
oddities:

Your calls to LIBXL__LOG all have a string starting ": ", eg:
> +            LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
> +                       ": at least one of the spiceport or tls_port must be 
> provided");

I don't think that's correct.  LIBXL__LOG should add all necessary
punctuation and I think if you run this it will produce output like:
  libxl: something: : at least one of the spiceport ....

Did you add the ": " after testing ?  If so then perhaps the existing
logging functions are wrong.


Secondly, your patch has a lot of rather long lines in new code.  Can
you please try to keep your lines down to 75 characters (or 80 if you
absolutely must) ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel