WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 06/14] libxl: disks: rename disk param "unpluggab

On Thu, 2011-05-12 at 15:36 +0100, Ian Jackson wrote:
> This property corresponds to what is called "removable" in xenstore,
> and is the conventional meaning of "removable": ie, the _media_ can be
> removed even as the _device_ remains present.
> 
> "unpluggable" is a misleading name for this.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 28e810c..97a1241 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -385,7 +385,7 @@ static void printf_info(int domid,
>          printf("\t\t\t(physpath %s)\n", d_config->disks[i].pdev_path);
>          printf("\t\t\t(phystype %d)\n", d_config->disks[i].backend);
>          printf("\t\t\t(virtpath %s)\n", d_config->disks[i].vdev);
> -        printf("\t\t\t(unpluggable %d)\n", d_config->disks[i].unpluggable);
> +        printf("\t\t\t(unpluggable %d)\n", d_config->disks[i].removable);
>          printf("\t\t\t(readwrite %d)\n", d_config->disks[i].readwrite);
>          printf("\t\t\t(is_cdrom %d)\n", d_config->disks[i].is_cdrom);
>          printf("\t\t)\n");

Does anybody actually use this thing? I find it hard to believe that it
is actually close enough to whatever it is suppose to mimic to be
useful...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>